[ovs-dev] [CudaMailTagged] [PATCH 0/2] Add color output to `ovs-ofctl dump-flows` command

Joe Stringer joe at ovn.org
Fri Feb 5 19:50:20 UTC 2016


On 5 February 2016 at 04:45, Quentin Monnet <quentin.monnet at 6wind.com> wrote:
> 2016-02-02 19:14 GMT+01:00 Ben Pfaff <blp at ovn.org>:
>
>> On Tue, Feb 02, 2016 at 09:31:22AM +0100, Quentin Monnet wrote:
>> > 2016-02-01 18:14 GMT+01:00 Ben Pfaff <blp at ovn.org>:
>> >
>> > > On Mon, Feb 01, 2016 at 04:40:44PM -0800, Quentin Monnet wrote:
>> > > > Proposal: add an option to ovs-ofctl utility so as to obtain
>> colorized
>> > > output
>> > > > in tty, for easier reading. Currently, only the dump-flows command
>> > > supports
>> > > > colors.
>> > > >
>> > > > A new `--color` option has been added to ovs-ofctl so as to indicate
>> > > > whether color markers should be used or not. It can be set to
>> `always`
>> > > > (force colors), `never` (no colors) or `auto` (use colors only if
>> output
>> > > > is a tty). If provided without any value, it is the same as `auto`.
>> If
>> > > > the option is not provided at all, colors are disabled by default.
>> > > >
>> > > > Quentin Monnet (2):
>> > > >   ovs-ofctl: add color output to dump-flows command
>> > > >   ovs-ofctl: complete color output for dump-flows command
>> > >
>> > > I don't see the actual patches.
>> > >
>> >
>> > Hi Ben, hi all,
>> > Indeed the emailed patches lost their way. I have just sent them again.
>>
>> Thanks.  I see them now.
>>
>
> Hi all,
> Does someone have an opinion about this kind of patches? Regardless of
> implementation details, is output coloring something that people find
> interesting for OVS? I made the patch because I found it somewhat difficult
> to read output from |ovs-ofctl dump-flows| (obviously). I do find it easier
> to read the flows with colors, and it could be extended to support output
> from other command / tools. But I would like to know if this seems to be an
> interesting feature to the community before I invest more time into it; so
> feedback is welcome!

I think it's a really neat addition and would love to see it for
ovs-dpctl too. Thanks for working on this!

Likewise I haven't taken a look beyond the screenshot (and I probably
won't as I'll be travelling for the next week).



More information about the dev mailing list