[ovs-dev] [PATCH] dpif-netdev: Add dpif-netdev/pmd-show-poll-lists appctl command.
Ilya Maximets
i.maximets at samsung.com
Mon Feb 8 07:44:26 UTC 2016
On 05.02.2016 23:18, Flavio Leitner wrote:
> If you are demoting an INFO log message, I would ask you tell in the NEWS
> file about that and the new command. I am saying this because I know people
> watching for that message to make sure it is working.
>
> Another concern is with the command name. We have:
> pmd-stats-<action> which can be "clear" or "show"
>
> you're proposing the opposite:
> pmd-<action>-<something>
>
> I believe we will want to have rx queue management done manually at some
> point in the future, so:
>
> pmd-set-<something> seems to be confusing
>
> Perhaps pmd-rxq-<action> ?
>
> pmd-rxq-show does what you propose, show the rxq for each pmd
> pmd-rxq-set we can get pmd id, port and queue id to pin
> pmd-rxq-clear to reset any fixed mapping
> pmd-rxq-stop to stop polling a specific queue
> pmd-rxq-start to start
> pmd-rxq-stats-show stats per queue?
> pmd-rxq-stats-clear ...
>
> Other than that the patch looks great and works for me.
> Thanks,
>
Thanks for review.
I like this naming style.
New version posted:
http://openvswitch.org/pipermail/dev/2016-February/065838.html
Best regards, Ilya Maximets.
More information about the dev
mailing list