[ovs-dev] [PATCH 2/3] sset: Make sset iteration check the type of the nodes it's iterating.

Russell Bryant russell at ovn.org
Tue Feb 9 01:45:41 UTC 2016


On 02/08/2016 07:52 PM, Ben Pfaff wrote:
> Without this additional check, SSET_FOR_EACH is happy to iterate over any
> type that has a struct hmap member named 'map'.  We have a number of these:
> hmapx, shash, simap, and smap, in addition to sset.
> 
> I guess another approach would be give each of these a unique member name,
> but the short name 'map' is nice too.
> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Acked-by: Russell Bryant <russell at ovn.org>

ACK on patch 1, as well.  I seem to have only received patch 2, and not
1 or 3.  They aren't in my spam folder, either.  :-/

-- 
Russell Bryant



More information about the dev mailing list