[ovs-dev] [PATCH 1/2] dist-docs: Properly pass "make" options into sub-make.

Ben Pfaff blp at ovn.org
Tue Feb 9 16:16:44 UTC 2016


On Tue, Feb 09, 2016 at 08:46:56AM -0500, Russell Bryant wrote:
> On 02/08/2016 11:18 PM, Ben Pfaff wrote:
> > In particular this ensures that the sub-make that dist-docs runs has the
> > benefit of any parallelism flags passed into the top-level make.
> > 
> > Signed-off-by: Ben Pfaff <blp at ovn.org>

> > diff --git a/build-aux/dist-docs b/build-aux/dist-docs
> > index 3792fa5..1aeefa7 100755
> > --- a/build-aux/dist-docs
> > +++ b/build-aux/dist-docs
> > @@ -44,7 +44,7 @@ rm -rf $distdir
> >  mkdir $distdir
> >  
> >  # Install manpages.
> > -make install-man mandir="$abs_distdir"/man
> > +${MAKE-make} install-man mandir="$abs_distdir"/man
> >  (cd $distdir && mv `find man -type f` . && rm -rf man)
> >  manpages=`cd $distdir && echo *`
> >  
> > 
> 
> I'm running "make -j5 dist-docs".  In both changes, ${MAKE} only
> evaluates to "make", so this doesn't seem to do what the commit message
> says.  Maybe you're building in a different way?

It's more magical than that.  Here, let me revise the commit message:
        http://openvswitch.org/pipermail/dev/2016-February/065935.html



More information about the dev mailing list