[ovs-dev] [PATCH] pinctrl: Fix byte order of numeric constant.

Russell Bryant russell at ovn.org
Wed Feb 10 21:18:31 UTC 2016


On 02/10/2016 04:17 PM, Ben Pfaff wrote:
> Found by sparse.
> 
> Fixes: commit 660f5a61286 ("ovn-controller: Use ofputil_encode_set_config to set the switch config")
> Reported-by: Russell Bryant <russell at ovn.org>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>  ovn/controller/pinctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovn/controller/pinctrl.c b/ovn/controller/pinctrl.c
> index 545ee47..97b7f6c 100644
> --- a/ovn/controller/pinctrl.c
> +++ b/ovn/controller/pinctrl.c
> @@ -98,7 +98,7 @@ pinctrl_recv(struct controller_ctx *ctx, const struct ofp_header *oh,
>          struct ofputil_switch_config config;
>  
>          ofputil_decode_get_config_reply(oh, &config);
> -        config.miss_send_len = htons(UINT16_MAX);
> +        config.miss_send_len = UINT16_MAX;
>          set_switch_config(swconn, &config);
>      } else if (type == OFPTYPE_PACKET_IN) {
>          process_packet_in(ctx, oh);
> 

Works for me.

Acked-by: Russell Bryant <russell at ovn.org>

-- 
Russell Bryant



More information about the dev mailing list