[ovs-dev] [PATCH RFC] netdev-dpdk: vhost-user: Fix sending packets to queues not enabled by guest.

Aaron Conole aconole at redhat.com
Thu Feb 11 17:31:34 UTC 2016


Hi Ilya,

Ilya Maximets <i.maximets at samsung.com> writes:

> Currently virtio driver in guest operating system have to be configured
> to use exactly same number of queues. If number of queues will be less,
> some packets will get stuck in queues unused by guest and will not be
> received.
>
> Fix that by using new 'vring_state_changed' callback, which is
> available for vhost-user since DPDK 2.2.
> Implementation uses additional mapping from configured tx queues to
> enabled by virtio driver. This requires mandatory locking of TX queues
> in __netdev_dpdk_vhost_send(), but this locking was almost always anyway
> because of calling set_multiq with n_txq = 'ovs_numa_get_n_cores() + 1'.
>
> Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
>  lib/netdev-dpdk.c | 108 +++++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 95 insertions(+), 13 deletions(-)
>

Thanks, so far looks good. You can put my Reviewed-by on this. I haven't
applied / tested, though. 

-Aaron



More information about the dev mailing list