[ovs-dev] [ovs-dev,V5] Add Passive TCP connection to IDL.

[Ofer Ben-Yacov]

The make check failed after git pull, but not in ovsdb tests, they passed
ok:

...
483: unixctl server - Python                         FAILED (
unixctl-py.at:96)
...
1529. monitor delete only (ovsdb-monitor.at:310): ok     (0m0.000s 0m0.000s)
1530. monitor modify only (ovsdb-monitor.at:318): ok     (0m0.000s 0m0.000s)
1531. simple passive idl, initially empty, select empty - Python ptcp (
ovsdb-idl.at:137): ok     (0m0.048s 0m0.004s)
1532. simple idl, initially empty, no ops - C (ovsdb-idl.at:145): ok
(0m0.000s 0m0.000s)
1533. simple idl, initially empty, no ops - Python (ovsdb-idl.at:145): ok
  (0m0.048s 0m0.004s)
1534. simple idl, initially empty, no ops - Python register_columns (
ovsdb-idl.at:145): ok     (0m0.040s 0m0.016s)
1535. simple idl, initially empty, no ops - Python tcp (ovsdb-idl.at:145):
ok     (0m0.036s 0m0.016s)
1536. simple idl, initially empty, no ops - Python tcp6 (ovsdb-idl.at:145):
ok     (0m0.048s 0m0.004s)
1537. simple idl, initially empty, various ops - C (ovsdb-idl.at:152): ok
  (0m0.000s 0m0.000s)
.....
1677: vlog - vlog/close - Python                      FAILED (vlog.at:309)
...
## ------------- ##
## Test results. ##
## ------------- ##

ERROR: 1754 tests were run,
2 failed unexpectedly.
1 test was skipped.
## -------------------------- ##
## testsuite.log was created. ##
## -------------------------- ##

Please send `tests/testsuite.log' and all information you think might help:

   To: <bugs at openvswitch.org>
   Subject: [openvswitch 2.5.90] testsuite: 483 1677 failed


....

Something on your side?!

Ofer.












‫בתאריך יום ו׳, 12 בפבר׳ 2016 ב-21:04 מאת ‪Russell Bryant‬‏ <‪
rbryant at redhat.com‬‏>:‬

> On 02/09/2016 04:25 AM, Ofer Ben-Yacov wrote:
> > From: Ofer Ben-Yacov <ofer.benyacov at gmail.com>
> >
> > Currently the IDL does not support passive TCP connection,
> > i.e. when the OVSDB connects to its manager.
> >
> > This patch enables IDL to use an already-open session
> > (the one which was previously used for retrieving the db schema).
> > In addition, it enables IDL to go back to "listen mode" in case the
> connection
> > is lost.
>
> I applied this patch and then ran "make check".  The new test case is
> failing for me.
>
> 1531: simple passive idl, initially empty, select empty - Python ptcp
> FAILED (ovsdb-idl.at:137)
>
> The log shows:
>
> Traceback (most recent call last):
>   File "../.././test-ovsdb.py", line 636, in <module>
>     main(sys.argv)
>   File "../.././test-ovsdb.py", line 631, in main
>     func(*args)
>   File "../.././test-ovsdb.py", line 444, in do_idl
>     rpc.run()
> AttributeError: 'NoneType' object has no attribute 'run'
>
>
> Does it work for you, or did a problem get introduced?
>
> --
> Russell Bryant
>