[ovs-dev] [PATCH] openflow-common: Describe length and padding rules for OpenFlow properties.

Ben Pfaff blp at ovn.org
Tue Feb 16 23:33:54 UTC 2016


I keep having to rediscover these from the code.  This is easier.

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 include/openflow/openflow-common.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/openflow/openflow-common.h b/include/openflow/openflow-common.h
index da2b7a5..8859400 100644
--- a/include/openflow/openflow-common.h
+++ b/include/openflow/openflow-common.h
@@ -221,6 +221,9 @@ enum ofp_port_features {
 struct ofp_prop_header {
     ovs_be16 type;
     ovs_be16 len;
+    /* Followed by:
+     *     - 'len - 4' bytes of payload.
+     *     - PAD_SIZE(len, 8) bytes of zeros. */
 };
 OFP_ASSERT(sizeof(struct ofp_prop_header) == 4);
 
@@ -234,6 +237,9 @@ struct ofp_prop_experimenter {
     ovs_be32 experimenter;  /* Experimenter ID which takes the same form as
                              * in struct ofp_experimenter_header. */
     ovs_be32 exp_type;      /* Experimenter defined. */
+    /* Followed by:
+     *     - 'len - 12' bytes of payload.
+     *     - PAD_SIZE(len, 8) bytes of zeros. */
 };
 OFP_ASSERT(sizeof(struct ofp_prop_experimenter) == 12);
 
-- 
2.1.3




More information about the dev mailing list