[ovs-dev] [PATCHv2 5/6] datapath: stt: Relax MTU constraints.

Joe Stringer joe at ovn.org
Fri Feb 19 18:55:23 UTC 2016


On 19 February 2016 at 10:44, Joe Stringer <joe at ovn.org> wrote:
> Currently, even if the entire path supports jumbo frames, the STT netdev
> limits the path MTU to 1500 bytes, and cannot be configured otherwise.
> Relax the constraints on modifying the device MTU, and set it to the
> maximum by default.
>
> Signed-off-by: Joe Stringer <joe at ovn.org>
> ---
> v2: Use dev->hard_header_len.
>     Follow upstream style.
>     Fix device registration leak on change_mtu failure.

I neglected to actually add this fragment into the commit, incremental:

diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
index 34efc4f56468..5b6857717091 100644
--- a/datapath/linux/compat/stt.c
+++ b/datapath/linux/compat/stt.c
@@ -1691,7 +1691,7 @@ static int __stt_change_mtu(struct net_device
*dev, int new_mtu, bool strict)
        if (new_mtu < 68)
                return -EINVAL;

-       if (new_mtu < 68) {
+       if (new_mtu > max_mtu) {
                if (strict)
                        return -EINVAL;



More information about the dev mailing list