[ovs-dev] [PATCH] autoconf: Fix missing AS_VAR_APPEND for version 2.63.

[William Tu]

Hi Ben,

I've tested the 3 patches using autoconf 2.63 and they work fine.
One minor thing is that the first patch has some extra space before
m4_define.

Regards,
William

On Mon, Feb 22, 2016 at 10:01 AM, Ben Pfaff <blp at ovn.org> wrote:

> On Wed, Feb 17, 2016 at 06:00:21PM -0800, William Tu wrote:
> > autoconf version 2.63 does not have AS_VAR_APPEND, resulting errors
> below:
> > tests/testsuite.tmp:3863: error: possibly undefined macro: AS_VAR_APPEND
> >       If this token and others are legitimate, please use
> m4_pattern_allow.
> >       See the Autoconf documentation.
> >       make[2]: *** [tests/testsuite] Error 1
> >
> > Signed-off-by: William Tu <u9012063 at gmail.com>
>
> Thanks for pointing out the problem, I'd forgotten about the need for
> backward compatibility here.
>
> However, this implementation is going to bite us eventually because it
> doesn't allow for polymorphic variable names, as in
> e.g. AS_VAR_APPEND([var$n], [123]).
>
> I sent out an alternative series, can you test it with Autoconf 2.63?
> Thanks.
>
> My series is:
>         https://patchwork.ozlabs.org/patch/586442/
>         https://patchwork.ozlabs.org/patch/586443/
>         https://patchwork.ozlabs.org/patch/586444/
>
> Thanks,
>
> Ben.
>