[ovs-dev] [ovs-dev, v5] ovn-controller: Assign zone-id consistently

ramu ramu.ramamurthy at gmail.com
Wed Feb 24 00:53:04 UTC 2016


Thanks for your review!

>
> From this part of the patch, it looks like external-ids:zone-id is
> accepted even if there are duplicates, or if the value is not valid.  I
> think that it should reject such cases:
>


> With that in mind, update_local_zone_ids() should also update
> external-ids:zone-id if it needs to change, instead of leaving it the
> same.
>
>
Here, please use INT_STRLEN(int) + 1 as the size of zone[].
> +        char zone[12];
> +        zone_id = simap_get(ct_zones, iface_id);
> +        snprintf(zone, sizeof zone, "%d", zone_id);
>
>
> In the next version I will incorporate these changes,



More information about the dev mailing list