[ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

Jarno Rajahalme jarno at ovn.org
Thu Feb 25 00:14:32 UTC 2016


Thanks for the reviews, series pushed to master.

  Jarno

> On Feb 23, 2016, at 8:21 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Wed, Feb 17, 2016 at 11:45:30AM -0800, Jarno Rajahalme wrote:
>> So far we have tried to optimize MPLS POP action not to recirculate
>> unless later matching actually needs the inner headers.  This made the
>> code complex and error-prone.  Also the cases where this optimization
>> would have been useful seem rare, as one would typically want to do
>> something else with the inner packet than blindly send it to some
>> output port.
>> 
>> With this change multiple consecutive MPLS POPs do not need
>> recirculation in between, so even if the blind output case is now
>> little bit less optimal, the multiple POP case is correspondingly
>> faster with this change.
>> 
>> Suggested-by: Ben Pfaff <blp at ovn.org>
>> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> 
> Thank you.
> 
> Acked-by: Ben Pfaff <blp at ovn.org>




More information about the dev mailing list