[ovs-dev] [PATCH v2 6/6] ofp-actions: color output of flow actions for ovs-ofctl dump-flows

Quentin Monnet quentin.monnet at 6wind.com
Thu Feb 25 07:44:46 UTC 2016


2016-02-24 1:01 GMT+01:00 Ben Pfaff <blp at ovn.org>:

> On Mon, Feb 15, 2016 at 04:22:07PM +0100, Quentin Monnet wrote:
> > Add color output for flow actions for ovs-ofctl dump-flows command
> > utility
> >
> > Signed-off-by: Quentin Monnet <quentin.monnet at 6wind.com>
>
> At a skim, I'm OK with the rest of this series.  It doesn't apply at the
> moment due to patch rejects, but that can be fixed.
>
> I have a suggestion that might make the code easier to read.  I haven't
> tried it so I'm not sure.
>

Hi Ben,
Many thanks for your feedback. I am working to address the issues you
pointed out, and I will definitely try your last suggestion for passing a
struct to the ds_put_format(). I will come back with a new version soon.



More information about the dev mailing list