[ovs-dev] [PATCH RFC] dpif-netdev: Allow different numbers of rx queues for different ports.

Ben Pfaff blp at ovn.org
Mon Jan 4 18:42:45 UTC 2016


On Tue, Dec 29, 2015 at 05:58:02PM +0300, Ilya Maximets wrote:
> Currently, all of the PMD netdevs can only have the same number of
> rx queues, which is specified in other_config:n-dpdk-rxqs.
> 
> Fix that by introducing of new option for PMD interfaces: 'n_rxq', which
> specifies the maximum number of rx queues to be created for this
> interface.
> 
> Example:
> 	ovs-vsctl set Interface dpdk0 options:n_rxq=8
> 
> Old 'other_config:n-dpdk-rxqs' deleted.
> 
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

The changes to the generic layers look OK to me.

I would add a note to NEWS to notify people of the change and the new
feature.

I think that the struct netdev needs an improved comment (currently it's
wrong, there's no synchronization on netdev_mutex and none needed),
something like this:

    /* The core netdev code initializes these at netdev construction and only
     * provide read-only access to its client.  Netdev implementations may
     * modify them. */
    int n_txq;
    int n_rxq;
    int requested_n_rxq;        /* Number of rx queues requested by user. */

Acked-by: Ben Pfaff <blp at ovn.org>

You should also get an ack from someone who knows netdev-dpdk, I did not
review that part.



More information about the dev mailing list