[ovs-dev] valgrind test 886 failed : ofproto-dpif - sFlow packet sampling - LACP structures

Ben Pfaff blp at ovn.org
Mon Jan 4 19:30:36 UTC 2016


On Tue, Dec 29, 2015 at 03:07:11PM -0800, William Tu wrote:
> Hi,
> 
> The latest ovs code with commit id
> (bdc30bfb5c02e1cc6142102423d14184e503487b) fails to run "make
> check-valgrind TESTSUITEFLAGS='886' ". However, it passes without valgrind.
> 
> The error is reproducible with error message:
> 886: ofproto-dpif - sFlow packet sampling - LACP structures FAILED (
> ofproto-dpif.at:5095)
> 
> Reason:
> at ofproto-dpif.at:5095, it expect "LACPUDsTx=1" but with check-valgrind,
> it prints "LACPUDsTx=3"
> 
> > LACPCOUNTERS sysID=11:22:33:44:55:66 partnerID=00:00:00:00:00:00
> aggID=3333 actorAdmin=0x7 actorOper=0xbf partnerAdmin=0x0 partnerOper=0x2
> LACPUDsRx=0 markerPDUsRx=4294967295 markerRespPDUsRx=4294967295
> unknownRx=4294967295 illegalRx=0 LACPUDsTx=3 markerPDUsTx=4294967295
> markerRespPDUsTx=4294967295
> 
> I have no idea how to fix it and is "LACPUD" a typo? which should be
> LACPDU? (DU for data unit?)

I think it's a typo, if you want to fix it that would be OK.

Possibly this is a race condition: maybe with valgrind more LACP
datagrams actually get sent.  Perhaps that is worth investigating.



More information about the dev mailing list