[ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

Ansis Atteka ansisatteka at gmail.com
Mon Jan 4 19:33:00 UTC 2016


On 4 January 2016 at 10:18, Ben Pfaff <blp at ovn.org> wrote:

> On Mon, Jan 04, 2016 at 09:36:34AM -0800, Ansis Atteka wrote:
> > On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff <blp at ovn.org> wrote:
> > > I think maybe you misinterpreted what I meant when I said "every
> > > caller".  When I said that, I meant "every program that invokes
> > > ovs-vsctl", not the entire call stack.
> >
> > William came to me to discuss this approach, If we both understood it
> > correctly, then it would be impossible to get the LINE number with it,
> > right?
>
> Yes.
>
> > Nevertheless, it would make comment generation simpler at expense of
> > printing only the parent process.
>
> It's a tradeoff.  I don't know the correct one.  I do know that
> sometimes it would have been useful, during debugging, to know what
> program invoked ovs-vsctl.
>

I just thought a little more about this. Third party code (e.g. libvirt)
also invokes ovs-vsctl and I believe it would be nice to be able to tell
such cases apart from those when user manually invoked ovs-vsctl manually
from ssh session or console. So parent process name would be helpful here.

The FILE+LINE part could be used to troubleshoot potential OVS internal
bugs, for example, to quickly be able to tell which OVS internal code
changed OVSDB by calling ovs-vsctl.

So how about printing both - PARENT PROCESS NAME+ID and FILE+LINE?


_______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list