[ovs-dev] [PATCH 3/4] ovs-ofctl: fix memory leak reported by valgrind, case 376

Ben Pfaff blp at ovn.org
Mon Jan 4 20:39:36 UTC 2016


On Thu, Dec 24, 2015 at 10:28:41AM -0800, William Tu wrote:
> Test case 376 reports two leaks:
>     ofpbuf_new(ofpbuf.c:151)
>     ofpraw_alloc_xid(ofp-msgs.c:533)
>     ofpraw_alloc(ofp-msgs.c:525)
>     ofputil_encode_flow_mod(ofp-util.c:2290)
>     bundle_flow_mod__(ovs-ofctl.c:1312)
>     ofctl_flow_mod__(ovs-ofctl.c:1331)
>     ofctl_flow_mod_file.isra.13(ovs-ofctl.c:1365)
>     ovs_cmdl_run_command(command-line.c:121)
>     main(ovs-ofctl.c:135)
> and
>     ofpraw_alloc(ofp-msgs.c:525)
>     ofputil_encode_flow_mod(ofp-util.c:2290)
>     fte_make_flow_mod(ovs-ofctl.c:2936)
>     ofctl_replace_flows(ovs-ofctl.c:2981)
>     ovs_cmdl_run_command(command-line.c:121)
>     main(ovs-ofctl.c:135)
> 
> Signed-off-by: William Tu <u9012063 at gmail.com>
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
> Co-authored-by: Daniele Di Proietto <diproiettod at vmware.com>

The change looks correct but please change it to use
ofpbuf_list_delete() instead of explicit loops.



More information about the dev mailing list