[ovs-dev] memory leak in recirc_state?

[ChengChun Tu]

Hi Ben,

Yes, Valgrind testcase 381 reports leak and generates the call stack below:
I tried to debug it for a while but not able to understand it. 


 fun:malloc
 fun:xmalloc
 fun:ofpbuf_new
 fun:ofpbuf_new_with_headroom
 fun:ofpbuf_clone_data_with_headroom
 fun:ofpbuf_clone_with_headroom
 fun:recirc_state_clone
 ...
 fun:recirc_alloc_id__
 fun:recirc_alloc_id_ctx
 fun:compose_recirculate_action__
 fun:xlate_actions


Regards,
William




On 1/5/16, 9:52 AM, "dev on behalf of Ben Pfaff" <dev-bounces at openvswitch.org on behalf of blp at ovn.org> wrote:

>Looking at the recirculation code in ofproto-dpif-rid.c, I see code to
>copy the stack and the actions from one recirc_state to another in
>recirc_state_clone(), but I can't find any code that ever frees them.
>recirc_run(), for example, just does a plain (postponed) "free" of the
>recirc_id_node (which has a recirc_state member).
>
>Is this a memory leak or am I just missing the code that frees this
>data?
>
>Thanks,
>
>Ben.
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>http://openvswitch.org/mailman/listinfo/dev