[ovs-dev] [PATCH] Add some more flake8 types to ignore list to fix the compilation errors

Numan Siddique nusiddiq at redhat.com
Wed Jan 6 11:47:45 UTC 2016


I guess this patch is not required, once Russel's patches on - Python style fixes and flake8 integration
are completely merged.


Thanks
Numan

On 01/06/2016 04:59 PM, Numan Siddique wrote:
> with the flake8 check enabled, ovs compilation is failing. This
> patch adds few more flake8 types to the igore list.
>
> Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 8b6ddb7..cb73ca6 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -349,7 +349,7 @@ ALL_LOCAL += flake8-check
>  # E129 visually indented line with same indent as next logical line
>  # E131 continuation line unaligned for hanging indent
>  flake8-check: $(FLAKE8_PYFILES)
> -	$(AM_V_GEN) if flake8 $^ --ignore=E123,E126,E127,E128,E129,E131 ${FLAKE8_FLAGS}; then touch $@; else exit 1; fi
> +	$(AM_V_GEN) if flake8 $^ --ignore=E123,E126,E127,E128,E129,E131,D100,D101,D102,D103,D104,D105,D200,D202,D204,D205,D207,D208,D209,D210,D400,D401,H104,H201,H231,H232,H233,H238,H301,H306,H401,H403,H404,H405 ${FLAKE8_FLAGS}; then touch $@; else exit 1; fi
>  endif
>  
>  include $(srcdir)/manpages.mk




More information about the dev mailing list