[ovs-dev] [PATCH 2/4] ovs-vsctl: fix memory leak reported by valgrind

William Tu u9012063 at gmail.com
Wed Jan 6 18:49:36 UTC 2016


test case 1: appctl-bashcomp - basic verification
Reason: args used without being free
Call stacks:
    ds_reserve (dynamic-string.c:63)
    ds_put_uninit (dynamic-string.c:73)
    ds_put_char__ (dynamic-string.c:82)
    ds_put_char (dynamic-string.h:89)
    process_escape_args (process.c:103)
    main (ovs-vsctl.c:150)

Signed-off-by: William Tu <u9012063 at gmail.com>
---
 utilities/ovs-vsctl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 36290db..8c2a252 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -2488,6 +2488,7 @@ do_vsctl(const char *args, struct ctl_command *commands, size_t n_commands,
     }
 
     ovsdb_idl_txn_add_comment(txn, "ovs-vsctl: %s", args);
+    free(args);
 
     ovs = ovsrec_open_vswitch_first(idl);
     if (!ovs) {
-- 
2.5.0




More information about the dev mailing list