[ovs-dev] [PATCH 1/2] Fix error log when subscribe/unsubscribe Windows

Sairam Venugopal vsairam at vmware.com
Wed Jan 6 23:09:40 UTC 2016


Acked-by: Sairam Venugopal <vsairam at vmware.com>


On 1/4/16, 3:04 PM, "Alin Serdean" <aserdean at cloudbasesolutions.com> wrote:

>The warning message was inverted on the performed operation.
>
>Also use the error returned by nl_sock_subscribe_packet__.
>
>Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>---
> lib/netlink-socket.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
>index 5cf1027..5ef4b15 100644
>--- a/lib/netlink-socket.c
>+++ b/lib/netlink-socket.c
>@@ -372,8 +372,8 @@ nl_sock_subscribe_packets(struct nl_sock *sock)
> 
>     error = nl_sock_subscribe_packet__(sock, true);
>     if (error) {
>-        VLOG_WARN("could not unsubscribe packets (%s)",
>-                  ovs_strerror(errno));
>+        VLOG_WARN("could not subscribe packets (%s)",
>+                  ovs_strerror(error));
>         return error;
>     }
>     sock->read_ioctl = OVS_IOCTL_READ_PACKET;
>@@ -388,8 +388,8 @@ nl_sock_unsubscribe_packets(struct nl_sock *sock)
> 
>     int error = nl_sock_subscribe_packet__(sock, false);
>     if (error) {
>-        VLOG_WARN("could not subscribe to packets (%s)",
>-                  ovs_strerror(errno));
>+        VLOG_WARN("could not unsubscribe to packets (%s)",
>+                  ovs_strerror(error));
>         return error;
>     }
> 
>-- 
>1.9.5.msysgit.0
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list