[ovs-dev] [PATCH 2/2] ovsdb-client: fix memory leak reported by valgrind

William Tu u9012063 at gmail.com
Thu Jan 7 23:53:09 UTC 2016


testc ase 1427: ovsdb-server combines updates on backlogged connections.
valgrind reports two leaks:
    unixctl_server_create (unixctl.c:250)
    do_monitor__ (ovsdb-client.c:918)
and
    json_create (json.c:1406)
    json_integer_create (json.c:262)
    json_clone (json.c:413)
    do_monitor__ (ovsdb-client.c:958)

Signed-off-by: William Tu <u9012063 at gmail.com>
---
 ovsdb/ovsdb-client.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
index 7a33ef8..06155ec 100644
--- a/ovsdb/ovsdb-client.c
+++ b/ovsdb/ovsdb-client.c
@@ -1037,6 +1037,9 @@ do_monitor__(struct jsonrpc *rpc, const char *database,
         unixctl_server_wait(unixctl);
         poll_block();
     }
+
+    json_destroy(request_id);
+    unixctl_server_destroy(unixctl);
     ovsdb_schema_destroy(schema);
     destroy_monitored_table(mts, n_mts);
 }
-- 
2.5.0




More information about the dev mailing list