[ovs-dev] [PATCH] utilities/ovs-vsctl.c: honor 'help' as ovs-ofctl and dpctl

Aaron Conole aconole at redhat.com
Mon Jan 11 18:53:14 UTC 2016


Ben Pfaff <blp at ovn.org> writes:
> On Tue, Jan 05, 2016 at 01:58:50PM -0500, Aaron Conole wrote:
>> Currently, ovs-ofctl and ovs-dpctl allow a 'help' keyword, in addition to -h
>> and --help. However, ovs-vsctl does not honor the same 'help' keyword. This
>> change adds a 'help' which redirects to usage(), bringing ovs-vsctl in line
>> with ovs-ofctl and ovs-dpctl.
>> 
>> Signed-off-by: Aaron Conole <aconole at redhat.com>
>
> I agree that it's useful to add such a command, but this is a poor
> implementation because it still tries to connect to the database.  For
> example, on my machine here:
>
>     blp at sigabrt:~/nicira/ovs/_build(0)$ utilities/ovs-vsctl help
>     ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection
> failed (No such file or directory)
>     blp at sigabrt:~/nicira/ovs/_build(1)$ 
>
> Not very helpful!

d'oh! Thanks, I missed that use case completely.

-Aaron



More information about the dev mailing list