[ovs-dev] possible memory leak at add_monitored_table()

[William Tu]

Hi Andy and Ben,

Sorry for making this mistake. I will be careful next time.

Regards,
William


On Mon, Jan 11, 2016 at 3:18 PM, Ben Pfaff <blp at ovn.org> wrote:

> It looks like William rolled this into his series and that I applied it
> earlier today.
>
> (William, when you do that, please be careful to retain the original
> author in the commit; this time it looks like you accidentally changed
> it to yourself.)
>
> On Thu, Jan 07, 2016 at 02:01:32PM -0800, Andy Zhou wrote:
> > Hi, William,
> >
> > I have posted a patch at
> >      https://patchwork.ozlabs.org/patch/564472/
> >
> > Would you please review and test the changes?  Thanks!
> >
> > --andy
> >
> > On Thu, Jan 7, 2016 at 11:48 AM, William Tu <u9012063 at gmail.com> wrote:
> >
> > > Hi,
> > >
> > > I'm running valgrind on testcase 1427: ovsdb-server combines updates on
> > > backlogged connections.
> > >
> > > valgrind reports the following two leaks and I haven't been able to
> fix it.
> > > Can anyone give me some hints about how to fix it? Thank you.
> > >
> > > ==104840== 896 bytes in 5 blocks are definitely lost in loss record 69
> of
> > > 70
> > > ==104840==    at 0x4C2AB9D: realloc (in
> > > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> > > ==104840==    by 0x423194: xrealloc (util.c:123)
> > > ==104840==    by 0x408E40: ovsdb_column_set_add (column.c:233)
> > > ==104840==    by 0x406FBF: add_column (ovsdb-client.c:730)
> > > ==104840==    by 0x407249: parse_monitor_columns (ovsdb-client.c:787)
> > > ==104840==    by 0x407531: add_monitored_table (ovsdb-client.c:872)
> > > ==104840==    by 0x40784C: do_monitor__ (ovsdb-client.c:945)
> > > ==104840==    by 0x407CE6: do_monitor (ovsdb-client.c:1037)
> > > ==104840==    by 0x405827: main (ovsdb-client.c:152)
> > > ==104840==
> > > ==104840== 1,216 bytes in 11 blocks are definitely lost in loss record
> 70
> > > of 70
> > > ==104840==    at 0x4C2AB9D: realloc (in
> > > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> > > ==104840==    by 0x423194: xrealloc (util.c:123)
> > > ==104840==    by 0x408E40: ovsdb_column_set_add (column.c:233)
> > > ==104840==    by 0x406FBF: add_column (ovsdb-client.c:730)
> > > ==104840==    by 0x407203: parse_monitor_columns (ovsdb-client.c:782)
> > > ==104840==    by 0x407531: add_monitored_table (ovsdb-client.c:872)
> > > ==104840==    by 0x40784C: do_monitor__ (ovsdb-client.c:945)
> > > ==104840==    by 0x407CE6: do_monitor (ovsdb-client.c:1037)
> > > ==104840==    by 0x405827: main (ovsdb-client.c:152)
> > >
> > > Regards,
> > > William
> > > _______________________________________________
> > > dev mailing list
> > > dev at openvswitch.org
> > > http://openvswitch.org/mailman/listinfo/dev
> > >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>