[ovs-dev] [PATCH 5/9] python: Fix xmlrpclib imports.

[Russell Bryant]

On 01/11/2016 08:39 PM, Ben Pfaff wrote:
> On Wed, Jan 06, 2016 at 03:50:25PM -0500, Russell Bryant wrote:
>> Fix imports of xmlrpclib to be compatible with Python 3.  Python 2 had
>> xmlrpclib (client) and SimpleXMLRPCServer (server).  In Python 3, these
>> have been renamed to xmlrpc.client and xmlrpc.server.
>>
>> The solution implemented here is to use the six library.  It may seem
>> excessive for this particular issue, but the six library provides
>> helpers for Python 2 and 3 compatibility for many different issues.
>> This is just the first of many uses of the six library.
>>
>> Signed-off-by: Russell Bryant <russell at ovn.org>
> 
> I guess that the intent is for python-six to be installed at build time
> and at runtime, right?

Yes, both.

> I guess we should add Python 2.7+ and Python six to the "Installation
> Requirements" section in INSTALL.md (so far they're only in the build
> requirements section, which I guess is an existing oversight).

Good point, I'll add it.

> Also we should update the various packaging to require python-six.
> Here's an appropriate patch for Debian (I think; it's untested because
> I've had patch conflicts):

I'll apply your incremental.  I'll have to rely on you or someone else
to test it, though.

I'll also apply the equivalent updates to the RPM spec file.

Thanks,

-- 
Russell Bryant