[ovs-dev] [PATCHv2] netdev-dpdk: Fix thread_is_pmd() symbol conflict.

Flavio Leitner fbl at sysclose.org
Tue Jan 12 20:39:29 UTC 2016


On Tue, 12 Jan 2016 11:32:41 -0800
Joe Stringer <joe at ovn.org> wrote:

> DPDK build was broken after commit 2f8932e8403a ("poll: Suppress
> logging for pmd threads.") due to the following error:
> 
> lib/netdev-dpdk.c:245:13: error: static declaration of ‘thread_is_pmd’
> follows non-static declaration
> lib/ovs-thread.h:526:6: note: previous declaration of ‘thread_is_pmd’
> was here
> 
> The version used in this file operates in the fastpath, so it cannot
> switch to using the newly introduced version; the new version lives
> outside of the dpdk portions of OVS so its implementation cannot be
> shared with this function. Rename it to resolve the conflict.
> 
> Fixes: 2f8932e8403a ("poll: Suppress logging for pmd threads.")
> Suggested-by: Flavio Leitner <fbl at sysclose.org>
> Signed-off-by: Joe Stringer <joe at ovn.org>
> ---
> 
> Here's the original failure:
> https://travis-ci.org/openvswitch/ovs/jobs/101648756
> 
> This Travis run should come up green:
> https://travis-ci.org/joestringer/openvswitch/builds/101922381
> ---
>  lib/netdev-dpdk.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

works for me
Acked-by: Flavio Leitner <fbl at sysclose.org>

Thanks for doing the V2!
-- 
fbl




More information about the dev mailing list