[ovs-dev] [PATCH v2] datapath: STT: Fix nf-hook softlockup.

[Joe Stringer]

On 13 January 2016 at 18:11, Joe Stringer <joe at ovn.org> wrote:
> On 13 January 2016 at 16:42, Pravin B Shelar <pshelar at nicira.com> wrote:
>> nf-hook is not unregistered on STT device delete, But when
>> second time it was created it nf-hook is again registered.
>> which causes following softlockup.
>> Following patch fixes it by registering nf-hook only on very
>> first stt device.
>>
>> ---8<---
>>
>> BUG: soft lockup - CPU#1 stuck for 22s! [ovs-vswitchd:11293]
>> RIP: 0010:[<ffffffffa0e48308>]  [<ffffffffa0e48308>] nf_ip_hook+0xf8/0x180 [openvswitch]
>> Stack:
>>  <IRQ>
>>  [<ffffffff8163bf60>] ? ip_rcv_finish+0x350/0x350
>>  [<ffffffff8163572a>] nf_iterate+0x9a/0xb0
>>  [<ffffffff8163bf60>] ? ip_rcv_finish+0x350/0x350
>>  [<ffffffff816357bc>] nf_hook_slow+0x7c/0x120
>>  [<ffffffff8163bf60>] ? ip_rcv_finish+0x350/0x350
>>  [<ffffffff8163c343>] ip_local_deliver+0x73/0x80
>>  [<ffffffff8163bc8d>] ip_rcv_finish+0x7d/0x350
>>  [<ffffffff8163c5e8>] ip_rcv+0x298/0x3d0
>>  [<ffffffff81605f26>] __netif_receive_skb_core+0x696/0x880
>>  [<ffffffff81606128>] __netif_receive_skb+0x18/0x60
>>  [<ffffffff81606cce>] process_backlog+0xae/0x180
>>  [<ffffffff81606512>] net_rx_action+0x152/0x270
>>  [<ffffffff8106accc>] __do_softirq+0xec/0x300
>>  [<ffffffff81710a1c>] do_softirq_own_stack+0x1c/0x30
>>
>> Fixes: fee43fa2 ("datapath: Fix deadlock on STT device destroy.")
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

FYI I merged this already to bumblebee. I'll follow up if there is
anything else related.