[ovs-dev] [PATCH 00/41] Implement "closures".

Jarno Rajahalme jarno at ovn.org
Tue Jan 19 18:56:27 UTC 2016


FYI,

I’ll review this series,

  Jarno

> On Jan 18, 2016, at 11:26 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> The purpose of this series is the final patch, which is important for
> OVN and should also solve some problems that I've heard of in other
> controllers over the years.
> 
> Ben Pfaff (41):
>  ofproto: Fix memory leak and memory exhaustion bugs in group_mod.
>  learning-switch: Use "if"s instead of "switch" to reduce maintenance.
>  ofp-msgs: Fix definitions of OF1.4 OFPT_GET_ASYNC_REPLY and
>    OFPT_SET_ASYNC.
>  ofp-msgs: Fix comments.
>  ofp-util: Improve formatting of comment.
>  openflow-1.2: Remove unused struct definition.
>  pinsched: Remove obsolete ofpbuf_trim().
>  ofp-print: Improve formatting of queue stat requests and port_mods.
>  openflow: Rename OF0.1-1.3 queue property constants.
>  netdev-dummy: Add a dummy queue.
>  ovs-ofctl: Merge dump_stats_transaction() into dump_transaction().
>  ofp-actions: Append in ofpacts_pull_openflow_actions(), instead of
>    replace.
>  ofp-util: Improve function to emit a bitmap property.
>  ofp-errors: Add extension error codes for OF1.3+ property errors.
>  ofp-prop: New module for working with OpenFlow 1.3+ properties.
>  ofp-prop: Add support for experimenter properties.
>  ofp-prop: Add generic functions for working with 16- and 32-bit
>    properties.
>  ofp-prop: Add helpers for u8, be64/u64, flag, and UUID properties.
>  ofp-prop: New function ofpprop_put_zeros().
>  openflow: Remove unused (and not useful) property headers.
>  openflow: Implement OF1.4+ OFPMP_QUEUE_DESC multipart message.
>  ofp-util: New function ofputil_async_msg_type_to_string().
>  ofp-util: Define struct ofputil_async_cfg to hold async message
>    config.
>  ofp-util: Rewrite async config encoding and decoding to be
>    table-driven.
>  ofp-util: Fix OF1.4+ version of ofputil_decode_set_async_config().
>  ofp-util: Add function to encode OFPT_SET_ASYNC messages.
>  ofp-print: Decode all async config messages the same way.
>  openflow: Get rid of struct ofp13_packet_in.
>  fail-open: Drop some of the weirder special cases.
>  pktbuf: Move from 'ofproto' to 'lib'.
>  openflow: Better abstract handling of packet-in messages.
>  connmgr: Generalize ofproto_packet_in to ofproto_async_msg.
>  hash: New helper functions hash_bytes32() and hash_bytes64().
>  ofproto-dpif-rid: Use array instead of ofpbuf for recirc_state stack.
>  ofproto-dpif-rid: Use separate pointers for actions and action set.
>  ofproto-dpif-rid: Don't carry actset_output explicitly in metadata.
>  ofproto-dpif-rid: Fix names of recirc_metadata_{hash,equal}().
>  ofproto-dpif-rid: Use UUID, not pointer, to identify ofprotos for
>    recirc.
>  nx-match: Add functions for raw decoding and encoding of OXM.
>  ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.
>  [RFC] Implement "closures".
> 
> NEWS                               |    8 +-
> OPENFLOW-1.1+.md                   |    5 +-
> include/openflow/nicira-ext.h      |   79 +-
> include/openflow/openflow-1.0.h    |   37 +-
> include/openflow/openflow-1.2.h    |    9 -
> include/openflow/openflow-1.3.h    |  104 +-
> include/openflow/openflow-1.4.h    |  128 +--
> include/openflow/openflow-1.5.h    |   18 -
> include/openflow/openflow-common.h |   72 +-
> lib/automake.mk                    |    6 +-
> lib/flow.h                         |    5 +-
> lib/hash.h                         |   14 +-
> lib/learning-switch.c              |  117 +--
> lib/meta-flow.c                    |    9 +-
> lib/meta-flow.h                    |    3 +-
> lib/netdev-dummy.c                 |   99 +-
> lib/nx-match.c                     |   30 +-
> lib/nx-match.h                     |    7 +-
> lib/odp-util.c                     |    5 +-
> lib/ofp-actions.c                  |   91 +-
> lib/ofp-actions.h                  |    9 +-
> lib/ofp-errors.h                   |   42 +-
> lib/ofp-msgs.c                     |   36 +-
> lib/ofp-msgs.h                     |   34 +-
> lib/ofp-print.c                    |  277 +++---
> lib/ofp-prop.c                     |  445 +++++++++
> lib/ofp-prop.h                     |  130 +++
> lib/ofp-util.c                     | 1937 +++++++++++++++++++++---------------
> lib/ofp-util.h                     |  156 ++-
> lib/ofpbuf.h                       |   19 +-
> {ofproto => lib}/pktbuf.c          |   44 +-
> {ofproto => lib}/pktbuf.h          |    3 +-
> lib/rconn.c                        |    4 +-
> ofproto/automake.mk                |    4 +-
> ofproto/connmgr.c                  |  323 ++----
> ofproto/connmgr.h                  |   52 +-
> ofproto/fail-open.c                |   29 +-
> ofproto/ofproto-dpif-rid.c         |   68 +-
> ofproto/ofproto-dpif-rid.h         |   25 +-
> ofproto/ofproto-dpif-upcall.c      |   29 +-
> ofproto/ofproto-dpif-xlate.c       |  269 +++--
> ofproto/ofproto-dpif-xlate.h       |    9 +-
> ofproto/ofproto-dpif.c             |  108 +-
> ofproto/ofproto-dpif.h             |   10 +-
> ofproto/ofproto-provider.h         |    5 +-
> ofproto/ofproto.c                  |  178 ++--
> ofproto/pinsched.c                 |   13 +-
> ovn/controller/pinctrl.c           |    4 +-
> tests/ofp-print.at                 |  117 ++-
> tests/ofproto-dpif.at              |   30 +
> tests/ofproto.at                   |  157 ++-
> utilities/ovs-ofctl.8.in           |   12 +-
> utilities/ovs-ofctl.c              |  202 ++--
> vswitchd/vswitch.xml               |   17 +-
> 54 files changed, 3449 insertions(+), 2194 deletions(-)
> create mode 100644 lib/ofp-prop.c
> create mode 100644 lib/ofp-prop.h
> rename {ofproto => lib}/pktbuf.c (76%)
> rename {ofproto => lib}/pktbuf.h (93%)
> 
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list