[ovs-dev] [PATCH 2/2] ovn: Fix localnet ports on the same chassis.

Russell Bryant russell at ovn.org
Tue Jan 19 20:39:39 UTC 2016


On 01/19/2016 10:27 AM, Kyle Mestery wrote:
> On Mon, Jan 18, 2016 at 9:45 AM, Russell Bryant <russell at ovn.org> wrote:
>> Multiple logical ports on the same chassis that were connected to the
>> same physical network via localnet ports were not able to send packets
>> to each other.  This was because ovn-controller created a single patch
>> port between br-int and the physical network access bridge and used it
>> for all localnet ports.
>>
>> The fix implemented here is to create a separate patch port for every
>> logical port of type=localnet.  An optimization is included where these
>> ports are only created if the localnet port is on a logical switch with
>> another logical port with an associated local VIF.
>>
>> A nice side effect of this fix is that the code in physical.c got a lot
>> simpler, as localnet ports are now handled mostly like local VIFs.
>>
>> Fixes: c02819293d52 ("ovn: Add "localnet" logical port type.")
>> Reported-by: Han Zhou <zhouhan at gmail.com>
>> Reported-at: http://openvswitch.org/pipermail/dev/2016-January/064413.html
>> Signed-off-by: Russell Bryant <russell at ovn.org>
> 
> I have tested this series out on a 4 node system (1 AIO control node, 2
> compute nodes, and a separate ovn-northd/OVSDB node), and it does indeed
> work as advertised! Nice work Russell!

Thanks for the test report!  Much appreciated.

> Tested-By: Kyle Mestery <mestery at mestery.com>
> Acked-By: Kyle Mestery <mestery at mestery.com>

I've added these to the commit, thanks again.

-- 
Russell Bryant



More information about the dev mailing list