[ovs-dev] [PATCH 20/41] openflow: Remove unused (and not useful) property headers.

[Jarno Rajahalme]

One unintentional (?) blank line added, otherwise:

Acked-by: Jarno Rajahalme <jarno at ovn.org>

> On Jan 18, 2016, at 11:27 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> These are all just copies of the otherwise generic ofp_prop_header or
> ofp_prop_experimenter.
> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
> include/openflow/openflow-1.3.h | 83 -----------------------------------------
> include/openflow/openflow-1.4.h | 45 +---------------------
> 2 files changed, 1 insertion(+), 127 deletions(-)
> 

(snip)

> diff --git a/include/openflow/openflow-1.4.h b/include/openflow/openflow-1.4.h
> index b65eeb8..bbdd54f 100644
> --- a/include/openflow/openflow-1.4.h
> +++ b/include/openflow/openflow-1.4.h
> @@ -223,12 +223,6 @@ OFP_ASSERT(sizeof(struct ofp14_queue_stats) == 48);
> /* ## Miscellaneous. ## */
> /* ## -------------- ## */
> 
> -/* Common header for all async config Properties */
> -struct ofp14_async_config_prop_header {
> -    ovs_be16    type;       /* One of OFPACPT_*. */
> -    ovs_be16    length;     /* Length in bytes of this property. */
> -};
> -OFP_ASSERT(sizeof(struct ofp14_async_config_prop_header) == 4);
> /* Request forward reason */
> enum ofp14_requestforward_reason {
>     OFPRFR_GROUP_MOD = 0,      /* Forward group mod requests. */
> @@ -237,6 +231,7 @@ enum ofp14_requestforward_reason {
> };
> 
> /* Async Config property types.
> +

Blank comment line should have ‘ *’ ?

> * Low order bit cleared indicates a property for the slave role.
> * Low order bit set indicates a property for the master/equal role.
> */
> @@ -257,29 +252,6 @@ enum ofp14_async_config_prop_type {
>     OFPTFPT_EXPERIMENTER_MASTER   = 0xFFFF, /* Experimenter for master. */
> };
> 

(snip)