[ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond
Liran Schour
LIRANS at il.ibm.com
Fri Jan 22 10:13:35 UTC 2016
Andy Zhou <azhou at ovn.org> wrote on 22/01/2016 06:42:01 AM:
> On Thu, Jan 21, 2016 at 8:04 PM, Russell Bryant <russell at ovn.org> wrote:
> On 01/21/2016 10:58 PM, Andy Zhou wrote:
> > I am not much of a python person. Hope some one more knowledgable with
> > python can review this.
>
> I'm happy to do Python reviews. I'll have to catch up on how this
> feature works first so I probably won't have a proper review until next
> week.
> Thanks Russell! I can also go through the it looking for logic
> issues. It would be great
> if you can provide feedback on python specific issues.
>
> As typical review goes, the code may still change as we work through
> the C implementation.
> In fact, If Liran is O.K. with this, we can consider spliting the
> python patch into its own patch series, and work
> through it after C implementation is committed.
The only problem is that the tests of IDL combines C and Python tests
together. I think that we should keep it like that any by that the patch
series will include the IDL tests for both C and Python.
Thanks for the dedicated review.
Will work on it and send a new version of the code hopefully during next
week.
More information about the dev
mailing list