[ovs-dev] [PATCH v4 1/2] dpif-netdev: Rework of rx queue management.

[Ilya Maximets]

Thank you very much.

Best regards, Ilya Maximets.

On 27.01.2016 08:05, Daniele Di Proietto wrote:
> Thanks for all your work!
> 
> I applied this to master and branch-2.5
> 
> On 25/01/2016 22:12, "Ilya Maximets" <i.maximets at samsung.com> wrote:
> 
>> Current rx queue management model is buggy and will not work properly
>> without additional barriers and other syncronization between PMD
>> threads and main thread.
>>
>> Known BUGS of current model:
>> 	* While reloading, two PMD threads, one already reloaded and
>> 	  one not yet reloaded, can poll same queue of the same port.
>> 	  This behavior may lead to dpdk driver failure, because they
>> 	  are not thread-safe.
>> 	* Same bug as fixed in commit e4e74c3a2b
>> 	  ("dpif-netdev: Purge all ukeys when reconfigure pmd.") but
>> 	  reproduced while only reconfiguring of pmd threads without
>> 	  restarting, because addition may change the sequence of
>> 	  other ports, which is important in time of reconfiguration.
>>
>> Introducing the new model, where distribution of queues made by main
>> thread with minimal synchronizations and without data races between
>> pmd threads. Also, this model should work faster, because only
>> needed threads will be interrupted for reconfiguraition and total
>> computational complexity of reconfiguration is less.
>>
>> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
>> ---