[ovs-dev] [PATCH 0/1] Fix Rhel spec file for kmod RPM

[Russell Bryant]

On 01/28/2016 08:48 AM, Thomas F Herbert wrote:
> In the process of building RPM's in OVS-OPNFV project, it was discovered that the
> Rhel spec file for building the kernel module RPM was broken in such a way to break
> depmod on kernel module installs.
> 
> This fixes the spec file be deleting the reference to openvswitch.conf.
> 
> Tested on Centos 7

The text here seems like it would be useful for the commit message.

I'm also pretty confused about the spec files and which ones are used
where.  While possibly unrelated to this patch, it would be really nice
if we could clear this up in some documentation.

We have:

    openvswitch.spec
    openvswitch-kmod-rhel6.spec

INSTALL.RHEL.md talks about these two.  It also only mentions RHEL 5 and 6.

    openvswitch-fedora.spec
    openvswitch-kmod-fedora.spec

INSTALL.Fedora.md talks about these.  It mentions the kmod-rhel6 spec
for Fedora 17.  Given that Fedora 17 is long gone, this piece can
probably be removed.

    openvswitch-dkms.spec

This last one is not referred to by any documentation, so it's not clear
where you would use it.

We don't mention RHEL/CentOS 7 anywhere.  I believe the Fedora spec is
actually used on CentOS 7.  Is that right?  In either case, can we
update the documentation to make it more clear where to go if you're
using RHEL/CentOS 7?

Finally, if that's the case, is this patch still needed?  I ask since
the issue was about the RHEL 6 spec used on CentOS 7.

</confused>

> 
> Thomas F Herbert (1):
>   Fix RHEL Spec file for kmod RPM install.
> 
>  rhel/openvswitch-kmod-rhel6.spec.in | 2 --
>  rhel/openvswitch-kmod.files         | 3 ---
>  2 files changed, 5 deletions(-)
>  delete mode 100644 rhel/openvswitch-kmod.files
> 


-- 
Russell Bryant