[ovs-dev] [PATCH 1/1] Openvswitch: RHEL: Fix RHEL Spec file for kmod RPM install.

[Thomas F Herbert]

On 1/28/16 11:07 AM, Guru Shetty wrote:
> It should ideally work. If not, it is a bug. Just to make sure that 
> you are doing the right thing, have you read the following piece of 
> instruction in INSTALL.RHEL.md <http://INSTALL.RHEL.md> carefully?
The "missing" file is openvswitch.conf which is pointed to by the file 
openvswitch-kmod.files. However, I admit that I have not tested it on 
RHEL6. I have only tested it on Centos 7. Also, Russel Bryant has 
submitted a separate patch today update the RHEL README to state that 
the Fedora Spec file for Centos 7 builds and that may address this issue 
for now.
>
> """
> On RHEL 6, to build the Open vSwitch kernel module, copy
>    rhel/openvswitch-kmod.files into the RPM sources directory and run:
>
> """
>
>
>
> On 28 January 2016 at 07:58, Thomas F Herbert 
> <thomasfherbert at gmail.com <mailto:thomasfherbert at gmail.com>> wrote:
>
>     On 1/28/16 10:27 AM, Guru Shetty wrote:
>>
>>
>>     On 28 January 2016 at 05:48, Thomas F Herbert
>>     <thomasfherbert at gmail.com <mailto:thomasfherbert at gmail.com>> wrote:
>>
>>         Signed-off-by: Thomas F Herbert <thomasfherbert at gmail.com
>>         <mailto:thomasfherbert at gmail.com>>
>>
>>
>>     The changes that this commit reverts were initially added as part
>>     of commit 9c12d2ec7569a12d9.
>>     So this commit will break the original fix.
>     I found this building the kmod on Centos 7 and the file
>     openvswitch.conf doesn't actually exist. Do Rhel 6 builds of the
>     out-of-tree kmod still work?
>
>>
>>         ---
>>          rhel/openvswitch-kmod-rhel6.spec.in
>>         <http://openvswitch-kmod-rhel6.spec.in> | 2 --
>>          rhel/openvswitch-kmod.files         | 3 ---
>>          2 files changed, 5 deletions(-)
>>          delete mode 100644 rhel/openvswitch-kmod.files
>>
>>         diff --git a/rhel/openvswitch-kmod-rhel6.spec.in
>>         <http://openvswitch-kmod-rhel6.spec.in>
>>         b/rhel/openvswitch-kmod-rhel6.spec.in
>>         <http://openvswitch-kmod-rhel6.spec.in>
>>         index 5d46838..6bd58f4 100644
>>         --- a/rhel/openvswitch-kmod-rhel6.spec.in
>>         <http://openvswitch-kmod-rhel6.spec.in>
>>         +++ b/rhel/openvswitch-kmod-rhel6.spec.in
>>         <http://openvswitch-kmod-rhel6.spec.in>
>>         @@ -19,7 +19,6 @@ Group: System/Kernel
>>          License:        GPLv2
>>          URL: http://openvswitch.org/
>>          Source0:        %{oname}-%{version}.tar.gz
>>         -Source1:        %{oname}-kmod.files
>>          BuildRoot:      %(mktemp -ud
>>         %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
>>          BuildRequires: %kernel_module_package_buildreqs
>>
>>         @@ -66,7 +65,6 @@ for flavor in %flavors_to_build ; do
>>                   find $INSTALL_MOD_PATH/lib/modules -iname
>>         'modules.*' -exec rm {} \;
>>          done
>>          install -d %{buildroot}%{_sysconfdir}/depmod.d/
>>         -install -m 644 %{oname}.conf
>>         %{buildroot}%{_sysconfdir}/depmod.d/
>>
>>          %clean
>>          rm -rf $RPM_BUILD_ROOT
>>         diff --git a/rhel/openvswitch-kmod.files
>>         b/rhel/openvswitch-kmod.files
>>         deleted file mode 100644
>>         index 357c2e8..0000000
>>         --- a/rhel/openvswitch-kmod.files
>>         +++ /dev/null
>>         @@ -1,3 +0,0 @@
>>         -%defattr(644,root,root,755)
>>         -/lib/modules/%2-%1
>>         -/etc/depmod.d/openvswitch.conf
>>         --
>>         2.5.0
>>
>>         _______________________________________________
>>         dev mailing list
>>         dev at openvswitch.org <mailto:dev at openvswitch.org>
>>         http://openvswitch.org/mailman/listinfo/dev
>>
>>
>
>