[ovs-dev] [PATCH v2] rhel: Make openvswitch-kmod-fedora.spec build.

Russell Bryant russell at ovn.org
Fri Jan 29 21:26:13 UTC 2016


On 01/29/2016 03:59 PM, Flavio Leitner wrote:
> On Fri, 29 Jan 2016 14:42:54 -0500
> Russell Bryant <russell at ovn.org> wrote:
> 
>> I tried building this package on Fedora 23 and it failed for a couple
>> of different reasons.
>>
>> This package tried to install modules without specifying the rpm build
>> root as an install prefix.  The result was just attempting to install
>> the modules on the system, which luckily failed since I wasn't running
>> rpmbuild as root.
>>
>> The package also then tried to manually install the modules into the
>> rpm build root, which is unnecessary once modules_install is pointed
>> to the right place.
>>
>> Finally, the package build failed with a completely unhelpful error
>> which turned out to be because it didn't know how to generate
>> a debuginfo pacakge.  I turned off the debug package for now.  At
>> least it builds now, which is an improvement.
>>
>> Signed-off-by: Russell Bryant <russell at ovn.org>
>> Suggested-by: Flavio Leitner <fbl at redhat.com>
>> ---
>>  rhel/openvswitch-kmod-fedora.spec.in | 24 +++++++++++++++---------
>>  1 file changed, 15 insertions(+), 9 deletions(-)
>>
>>
>> v1->v2:
>>  - Apply fixes suggested by Flavio, to exclude files we shouldn't
>> package and to add depmod override config
>>
> 
> Acked-by: Flavio Leitner <fbl at redhat.com>
> 
> Thanks Russel!

Thanks for the help!  I pushed this to master with the acks from you and
Guru.

-- 
Russell Bryant



More information about the dev mailing list