[ovs-dev] [PATCH v5 00/11] Windows: Add support for debugging conntrack from userspace

Nithin Raju nithin at vmware.com
Fri Jul 1 20:54:51 UTC 2016


Good job with all the patches! I believe I have acked all of them. Thanks
for addressing all the comments.

-----Original Message-----
From: dev <dev-bounces at openvswitch.org> on behalf of Sairam Venugopal
<vsairam at vmware.com>
Date: Friday, July 1, 2016 at 1:49 PM
To: "dev at openvswitch.org" <dev at openvswitch.org>
Subject: [ovs-dev] [PATCH v5 00/11] Windows: Add support for
debugging	conntrack from userspace

>Conntrack module is part of OVS datapath on Windows and lacks netlink
>support. The following patches adds support in Windows datapath for
>accepting netfilter-netlink messages from userspace and executing the
>command. The supported commands include flushing conntrack entries and
>dumping them.
>
>v2: Addresed review comments from Paul Boca <pboca at cloudbasesolutions.com>
>v3: Added the ACKED-BY for the ones that were acked
>v4: Addresed review comments from Nithin Raju <nithin at vmware.com>
>v5: Addresed review comments from Nithin Raju <nithin at vmware.com>
>
>Sairam Venugopal (11):
>  Windows: Add conntrack netfilter netlink definitions to kernel and
>    userspace
>  datapath-windows: Add support for Netfilter netlink message
>  datapath-windows: Add new NlFillOvsMsgForNfGenMsg method in Netlink.c
>  datapath-windows: Add support for flushing conntrack entries
>  datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_DELETE cmd
>    in Datapath.c
>  datapath-windows: Add support for dump-conntrack in datapath
>  datapath-windows: Conntrack - Handle memory allocation failure
>  datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_GET cmd in
>      Datapath.c
>  datapath-windows: Track the number of conntrack entries
>  Windows: Add conntrack dump and flush support in userspace
>  Windows: Ignore the dpif conversions for windows in
>    netlink-conntrack.c
>
> build-aux/extract-odp-netlink-h                    |   1 +
> datapath-windows/automake.mk                       |   1 +
> datapath-windows/include/OvsDpInterfaceCtExt.h     | 423 +++++++++++++++
> datapath-windows/include/OvsDpInterfaceExt.h       |   7 +
> datapath-windows/ovsext/Conntrack-other.c          |   5 +-
> datapath-windows/ovsext/Conntrack-tcp.c            |  63 +++
> datapath-windows/ovsext/Conntrack.c                | 566
>++++++++++++++++++++-
> datapath-windows/ovsext/Conntrack.h                |   5 +
> datapath-windows/ovsext/Datapath.c                 |  70 ++-
> datapath-windows/ovsext/Netlink/Netlink.c          |  50 ++
> datapath-windows/ovsext/Netlink/Netlink.h          |  13 +-
> datapath-windows/ovsext/Netlink/NetlinkProto.h     |   9 +
> datapath-windows/ovsext/Util.h                     |   4 +
> datapath-windows/ovsext/ovsext.vcxproj             |   1 +
> datapath-windows/ovsext/precomp.h                  |   1 +
> include/windows/automake.mk                        |   6 +
> .../windows/linux/netfilter/nf_conntrack_common.h  |   0
> include/windows/linux/netfilter/nf_conntrack_ftp.h |   0
> .../windows/linux/netfilter/nf_conntrack_sctp.h    |   0
> include/windows/linux/netfilter/nf_conntrack_tcp.h |   0
> include/windows/linux/netfilter/nfnetlink.h        |   0
> .../windows/linux/netfilter/nfnetlink_conntrack.h  |   0
> lib/automake.mk                                    |   2 +
> lib/dpif-netlink.c                                 |  15 +-
> lib/netlink-conntrack.c                            |  51 +-
> 25 files changed, 1261 insertions(+), 32 deletions(-)
> create mode 100644 datapath-windows/include/OvsDpInterfaceCtExt.h
> create mode 100644 include/windows/linux/netfilter/nf_conntrack_common.h
> create mode 100644 include/windows/linux/netfilter/nf_conntrack_ftp.h
> create mode 100644 include/windows/linux/netfilter/nf_conntrack_sctp.h
> create mode 100644 include/windows/linux/netfilter/nf_conntrack_tcp.h
> create mode 100644 include/windows/linux/netfilter/nfnetlink.h
> create mode 100644 include/windows/linux/netfilter/nfnetlink_conntrack.h
>
>-- 
>2.5.0.windows.1
>
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pN
>HQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=59qaGLQBispOboXb0ITbRJf3MBSe48
>ShAXR-JycKVIg&s=zkOfiUo78vJHFGojVp2OwwZoiao7w9kQAF66qDLbnME&e= 




More information about the dev mailing list