[ovs-dev] [PATCH 2/2] utilities: ovs-ctl.in: Allow passing DPDK options to ovs-vswitchd

[Markos Chandras]

On 07/02/2016 03:22 AM, Aaron Conole wrote:
> Markos Chandras <mchandras at suse.de> writes:
> 
>> The ovs-ctl script is used to launch ovs-vswitchd among other things.
>> However it does not make it possible to pass DPDK options to the
>> daemon. We fix this by explicitly looking and extracting the DPDK
>> options from the command line which is then reconstructed so it can be
>> parsed by ovs-ctl as usual. The DPDK options are later passed to
>> ovs-vswitchd.
>>
>> Signed-off-by: Markos Chandras <mchandras at suse.de>
>> ---
>>  utilities/ovs-ctl.in | 34 ++++++++++++++++++++++++++++++++--
>>  1 file changed, 32 insertions(+), 2 deletions(-)
>>
>> diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
>> index 8ec825b..b4e7bf1 100755
>> --- a/utilities/ovs-ctl.in
>> +++ b/utilities/ovs-ctl.in
>> @@ -230,7 +230,12 @@ do_start_forwarding () {
>>          fi
>>  
>>          # Start ovs-vswitchd.
>> -        set ovs-vswitchd unix:"$DB_SOCK"
>> +        set ovs-vswitchd
>> +        # DPDK options are expected to be at the beginning of
>> +        # the command line arguments. Add '--' to mark the end
>> +        # of the DPDK options.
>> +        [ -n "$DPDK_OPTS" ] && set -- "$@" $DPDK_OPTS "--"
>> +        set "$@" unix:"$DB_SOCK"
> 
> NAK - this doesn't work on the latest version of Open vSwitch.
> 

Oh yes right. I only tested that with 2.5.0 but now I see that even the
2.5 branch has changed in that regard.

-- 
markos

SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg