[ovs-dev] [PATCH] build: Skip datapath subdir on Windows
Alin Serdean
aserdean at cloudbasesolutions.com
Sun Jul 3 17:06:19 UTC 2016
> De la: Ben Pfaff [mailto:blp at ovn.org]
> Trimis: Friday, July 1, 2016 11:31 PM
> Către: Alin Serdean <aserdean at cloudbasesolutions.com>
> Cc: dev at openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] build: Skip datapath subdir on Windows
>
> I think that this will make "make dist" on Windows omit the datapath
> directory. If I'm right about that, then it's unacceptable because the
> distribution tarball should be the same regardless of where it's built.
[Alin Gabriel Serdean: ] You are right Ben, I did not think about it.
>
> I'd suggest putting the if...endif block into datapath/Makefile.am, like
> this:
[Alin Gabriel Serdean: ] I will resend the patch and add you as co-author. Thanks for the for the snippet.
>
> diff --git a/datapath/Makefile.am b/datapath/Makefile.am index
> 458fa5b..f2a85bc 100644
> --- a/datapath/Makefile.am
> +++ b/datapath/Makefile.am
> @@ -30,6 +30,7 @@ print-build-modules:
> fi
> @echo "$(build_modules)" | tr '_' '-';
>
> +if !WIN32
> COMPAT_GET_FUNCTIONS := find $(top_srcdir)/datapath/linux/compat -
> name "*.h" \
> -exec sed -n '/^[a-z][a-z]* \*\?[A-Za-z0-9_][A-Za-z0-9_]*([a-z]/p;
> /^struct [a-z0-9_][a-z0-9_]* \*\?[A-Za-z0-9_][A-Za-z0-9_]*([a-z]/p' {} \; | tr -
> d '*' | cut -d '(' -f1 | rev | cut -d ' ' -f1 | rev COMPAT_GET_EXPORTS := find
> $(top_srcdir)/datapath/linux/compat -name "*.c" \ @@ -56,3 +57,4 @@
> check-export-symbol:
> done
>
> all-local: check-export-symbol
> +endif
More information about the dev
mailing list