[ovs-dev] [PATCH v3] Makefile.am: Add clang static analysis support

[Ben Pfaff]

On Sun, Jul 03, 2016 at 04:22:40PM +0100, Bhanuprakash Bodireddy wrote:
> Clang Static Analyzer is a source code analysis tool to find bugs. This
> patch adds make target to trigger static analysis using below commands.
> 
> ./boot.sh
> For Clang: ./configure CC=clang --with-dpdk
> For GCC: ./configure CC=gcc --with-dpdk CFLAGS="-std=gnu99"
> make clang-analyze
> scan-view --host=<ip address> --port <PORT>
>   $OVS_DIR>/clang-analyzer-results/yyyy-mm-dd-114251-1027-1>
>   --allow-all-hosts
> 
> Results can be viewed on browser: http://<ip address>:<PORT>/
> 
> v2->v3:
> * Refactor the code as suggested.
> * Add --use-cc to scan-build.
> 
> v1->v2:
> * Change the output directory to tests/clang-analyzer-results
> * Remove '-j' make option, This might potentially hang some system
>   while spawning infinite jobs.
> 
> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy at intel.com>

This version works for me as long as I'm using Clang as the compiler.

Why is /usr/bin/clang hard-coded as the analyzer, even though "which"
will look throughout $PATH?

$(CC) needs to be written '$(CC)' in case there are spaces.

Please add a note to INSTALL.md explaining that this is available.