[ovs-dev] [PATCH 4/7] ovn-northd: Introduce stateful table.

Guru Shetty guru at ovn.org
Sun Jul 3 20:06:13 UTC 2016


On 2 July 2016 at 21:42, Ben Pfaff <blp at ovn.org> wrote:

> On Wed, Jun 29, 2016 at 01:17:08AM -0700, Gurucharan Shetty wrote:
> > Currently, the only use of stateful services in conntrack is
> > OVN ACLs. In table ACL, we commit the packet to conntrack
> > via ct_commit action.
> >
> > As we introduce more stateful services, the ACL feature will
> > have to share the conntrack module with others. As
> > preparation for more stateful features like load balancing,
> > this commit introduces a new stateful table
> > that is responsible to commit packets to conntrack via
> > ct_commit action. If ACL table needs to commit a packet,
> > it sets 'reg0[1]' as 1. Stateful table in-turn will commit
> > the packet if 'reg0[1]' is 1.
> >
> > Signed-off-by: Gurucharan Shetty <guru at ovn.org>
>
> s/initiater's/initiator's/ in the documentation.
>

Fixed it.

>
> The code introduces symbolic names, or at least macros, for reg0[0] and
> reg0[1].  Do you think that the documentation would be improved by
> giving these bits names for reference?  I do not know for sure, but
> maybe it would make the documentation easier to understand.
>

I couldn't quite fit in a non-controversial wording that could be committed
without a review. I will come up with a separate documentation fix up.


>
> Acked-by: Ben Pfaff <blp at ovn.org>
>
Thanks, I applied the first 4 patches of the series.

> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list