[ovs-dev] [PATCH 2/2] utilities: ovs-ctl.in: Allow passing DPDK options to ovs-vswitchd

[Markos Chandras]

On 07/05/2016 03:08 PM, Aaron Conole wrote:
> Markos Chandras <mchandras at suse.de> writes:
> 
>> On 07/02/2016 03:22 AM, Aaron Conole wrote:
>>> Markos Chandras <mchandras at suse.de> writes:
>>>
>>>> The ovs-ctl script is used to launch ovs-vswitchd among other things.
>>>> However it does not make it possible to pass DPDK options to the
>>>> daemon. We fix this by explicitly looking and extracting the DPDK
>>>> options from the command line which is then reconstructed so it can be
>>>> parsed by ovs-ctl as usual. The DPDK options are later passed to
>>>> ovs-vswitchd.
>>>>
>>>> Signed-off-by: Markos Chandras <mchandras at suse.de>
>>>> ---
>>>>  utilities/ovs-ctl.in | 34 ++++++++++++++++++++++++++++++++--
>>>>  1 file changed, 32 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
>>>> index 8ec825b..b4e7bf1 100755
>>>> --- a/utilities/ovs-ctl.in
>>>> +++ b/utilities/ovs-ctl.in
>>>> @@ -230,7 +230,12 @@ do_start_forwarding () {
>>>>          fi
>>>>  
>>>>          # Start ovs-vswitchd.
>>>> -        set ovs-vswitchd unix:"$DB_SOCK"
>>>> +        set ovs-vswitchd
>>>> +        # DPDK options are expected to be at the beginning of
>>>> +        # the command line arguments. Add '--' to mark the end
>>>> +        # of the DPDK options.
>>>> +        [ -n "$DPDK_OPTS" ] && set -- "$@" $DPDK_OPTS "--"
>>>> +        set "$@" unix:"$DB_SOCK"
>>>
>>> NAK - this doesn't work on the latest version of Open vSwitch.
>>>
>>
>> Oh yes right. I only tested that with 2.5.0 but now I see that even the
>> 2.5 branch has changed in that regard.
> 
> Oh, this is for 2.5;  I'm not sure about it then.

Yeah me neither. It's certainly convenient to be able to use
/etc/sysconfig/openvswitch to pass all the dpdk options but since that
has been fixed in a better way in master perhaps it does not matter
match. In any case, I could submit a reworked patch and see what happens.

I don't know if there
> is such a process to write commits for specific releases, but since 2.5
> is an LTS release it might make sense.  As far as I understand, 2.5 will
> not backport the dpdk database changes.
> 
> It may acceptable to add something a bit more generic though.  I'm
> thinking there could be some variables as:
> 
> OVSDB_SERVER_EXTRA
> OVS_VSWITCHD_EXTRA

Just to make sure we are on the same page, you mean to use these in
/etc/sysconfig/openvswitch (much like OPTIONS) and then treat them as
environmental variables in ovs-ctl right? because merging them with
OPTIONS and passing all of them as arguments is going to be slightly ugly :)

-- 
markos

SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg