[ovs-dev] [PATCH] vlog.py: Remove redundant setLevel() if "/dev/log" doesn't exist

Guru Shetty guru at ovn.org
Wed Jul 6 23:49:15 UTC 2016


On 6 July 2016 at 16:41, Daniele Di Proietto <diproiettod at vmware.com> wrote:

> Also update a comment.
>
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
>
Acked-by: Gurucharan Shetty <guru at ovn.org>


> ---
>  python/ovs/vlog.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/python/ovs/vlog.py b/python/ovs/vlog.py
> index 49210b8..48d52ad 100644
> --- a/python/ovs/vlog.py
> +++ b/python/ovs/vlog.py
> @@ -298,11 +298,10 @@ class Vlog(object):
>              return
>
>          logger = logging.getLogger('syslog')
> -        # If there is no infrastructure to support python syslog, increase
> -        # the logging severity level to avoid repeated errors.
> +        # If there is no infrastructure to support python syslog, disable
> +        # the logger to avoid repeated errors.
>          if not os.path.exists("/dev/log"):
>              logger.disabled = True
> -            logger.setLevel(logging.CRITICAL)
>              return
>
>          if syslog_handler:
> --
> 2.8.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list