[ovs-dev] [PATCH v2] ovn-controller: Change strategy for gateway conntrack zone allocation.

[Guru Shetty]

On 8 July 2016 at 16:10, Ryan Moats <rmoats at us.ibm.com> wrote:

> "dev" <dev-bounces at openvswitch.org> wrote on 07/08/2016 06:27:03 AM:
>
> > From: Gurucharan Shetty <guru at ovn.org>
> > To: dev at openvswitch.org
> > Date: 07/08/2016 04:25 PM
> > Subject: [ovs-dev] [PATCH v2] ovn-controller: Change strategy for
> > gateway conntrack zone allocation.
> > Sent by: "dev" <dev-bounces at openvswitch.org>
> >
> > Commit 263064aeaa31e7 (Convert binding_run to incremental processing.)
> > changed the way patched_datapaths were handled. Previously we would
> > destroy the datastructure in every run and re-create it fresh. The new
> > way causes problems with the way conntrack zones are allocated as now
> > we can have stale port_binding entries causing segmentation faults.
> >
> > With this commit, we simply don't depend on port_binding records in
> > conntrack zone allocation and instead store the UUID as a string in
> > the patch_datapath datastructure.
> >
> > (The test enhanced with this commit would fail without the changes
> > in the commit. i.e. ovn-controller would crash. )
> >
> > Signed-off-by: Gurucharan Shetty <guru at ovn.org>
> > ---
>
> I've tried this out and verified that the enhanced test does fail/crash
> w/o the patch and passes w/ it so...
>
> Acked-by: Ryan Moats <rmoats at us.ibm.com>
>
Thank you, applied!