[ovs-dev] [ovs-dev, PATCHv3] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

[William Tu]

Hi Daniel,

Thanks for reviewing the patch.
Indeed, the way sFlow sets up the datapath does not require the
OpenFlow sample action, and changing OVSDB/compose_sample_action() is
sufficient to program the datapath sample action for current sFlow use
case. So if IPFIX does not use 'snaplen', or there is no future use
case, then I could remove the snaplen in "struct nx_action_sample2".

Regards,
William

On Sun, Jul 10, 2016 at 7:46 PM, Daniel Ye <daniely at vmware.com> wrote:
> Hi William,
>
>
>
> I saw that you submitted the patch below. It’s about adding ‘snaplen’ for
> sample action and sFlow.
>
> https://patchwork.ozlabs.org/patch/645013/
>
>
>
> I’m still confused whether sFlow uses the openflow sample action. In my
> opinion, sFlow only uses the datapath
>
> sample action, not the sample action in userworld. Actually, there are two
> kinds of IPFIX, one is bridge level IPFIX and the
>
> other is flow-based IPFIX. Bridge level IPFIX doesn’t use openflow sample
> action, it only uses the datapath sample action. I think
>
> sFlow does the same as bridge level IPFIX. For bridge level IPFIX and sFlow,
> all the parameters are stored in OVSDB.
>
>
>
> Actually, “nx_action_sample2” is only used by flow-based IPFIX now. If you
> add a ‘snaplen’ field in it, I don’t think this field
>
> will be used by sFlow. Maybe you only need to change
> “compose_sample_action()” and put ‘snaplen’ in OVSDB??
>
>
>
> For all the alias, does any sFlow experts come to make sure of this?
>
>
>
> Thanks,
>
> Daniel Benli Ye