[ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

Zong Kai Li zealokii at gmail.com
Tue Jul 12 11:26:29 UTC 2016


On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit <jpettit at ovn.org> wrote:
> Rename "compose_nd" and "compose_na" to "compose_nd_sol" and
> "compose_nd_adv", respecively, to be clearer about their functionality.
> Also change the source and destination IPv6 addresses to take
> "struct in6_addr" arguments, which are more common in the code base.
>
> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> ---

>      eth_compose(b, eth_dst, eth_src, ETH_TYPE_IPV6, IPV6_HEADER_LEN);
> -    na = compose_ipv6(b, IPPROTO_ICMPV6, ipv6_src, ipv6_dst, 0, 0, 255,
> -                      ND_MSG_LEN + ND_OPT_LEN);
> +    na = compose_ipv6(b, IPPROTO_ICMPV6,
> +                      ALIGNED_CAST(ovs_be32 *, ipv6_src->s6_addr),
> +                      ALIGNED_CAST(ovs_be32 *, ipv6_dst->s6_addr),
> +                      0, 0, 255, ND_MSG_LEN + ND_OPT_LEN);
>

Hi, Justin. It's quite a long time to wait support for IPv6, but I
think it worth. Thanks. :)

About using ALIGNED_CAST, would you mind checking
http://patchwork.ozlabs.org/patch/632026/ ?
Ben has a comment said "Using ALIGNED_CAST does not solve a problem,
it only suppresses a warning.".
So I'm not sure will this be a good way to cleanup.

Thanks.
Zong Kai, LI



More information about the dev mailing list