[ovs-dev] [PATCH V6 09/17] python tests: Fixed OSError not iterable on Windows

Alin Serdean aserdean at cloudbasesolutions.com
Tue Jul 12 19:00:30 UTC 2016


I am wondering why you get an OSError instead of a select error?
The order of the exception should be inverted (first the select one and after the OSerror one), or add a general exception at the end.

Thanks,
Alin.
> -----Mesaj original-----
> De la: dev [mailto:dev-bounces at openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July 6, 2016 3:38 PM
> Către: dev at openvswitch.org
> Subiect: [ovs-dev] [PATCH V6 09/17] python tests: Fixed OSError not iterable
> on Windows
> 
> On Windows if this exception is triggered then it will raise an exception while
> in the exception handler.
> 
> 
>  try:
>      import eventlet.patcher
> @@ -168,6 +169,10 @@ class Poller(object):
>              try:
>                  events = self.poll.poll(self.timeout)
>                  self.__log_wakeup(events)
> +            except OSError as e:
> +                error = e.errno
> +                if error != errno.EINTR:
> +                    vlog.err("poll: %s" % os.strerror(e.errno))
>              except select.error as e:
>                  # XXX rate-limit
>                  error, msg = e
> --
> 2.7.2.windows.1
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev


More information about the dev mailing list