[ovs-dev] [ovn-ipv6 05/26] Introduce 128-bit xxregs.

[Ben Pfaff]

On Tue, Jul 12, 2016 at 05:16:32PM -0700, Justin Pettit wrote:
> 
> > On Jul 12, 2016, at 4:15 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > On Mon, Jul 11, 2016 at 11:56:35PM -0700, Justin Pettit wrote:
> >> These are needed to handle IPv6 addresses.
> >> 
> >> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> > 
> > I don't think that flow_get_xxreg() and flow_set_xxreg() are endian
> > independent.  That is, suppose that actions set reg0, reg1, reg2, and
> > reg3 independently, and then read xxreg0.  Will xxreg0 have the same
> > value on big-endian and little-endian architectures?  That is something
> > that we guarantee for the xregs, so it would be bad to drop it for
> > xxregs.
> 
> Ugh, good catch.  I've appended a diff that should address this.  Let
> me know if you see any problems.

There's a test, so anything we missed should get caught on the first
big-endian build, which makes me unworried.

Thanks,

Ben.