[ovs-dev] [PATCH 19/24] datapath: backport: ovs: do not allocate memory from offline numa node
Pravin B Shelar
pshelar at ovn.org
Wed Jul 13 05:26:42 UTC 2016
Upstream commit:
commit 598c12d0ba6de9060f04999746eb1e015774044b
Author: Konstantin Khlebnikov <khlebnikov at yandex-team.ru>
ovs: do not allocate memory from offline numa node
When openvswitch tries allocate memory from offline numa node 0:
stats = kmem_cache_alloc_node(flow_stats_cache, GFP_KERNEL | __GFP_ZERO, 0)
It catches VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES || !node_online(nid))
[ replaced with VM_WARN_ON(!node_online(nid)) recently ] in linux/gfp.h
This patch disables numa affinity in this case.
Signed-off-by: Konstantin Khlebnikov <khlebnikov at yandex-team.ru>
Acked-by: Pravin B Shelar <pshelar at ovn.org>
Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Pravin B Shelar <pshelar at ovn.org>
---
datapath/flow_table.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/datapath/flow_table.c b/datapath/flow_table.c
index dd77922..466b2b7 100644
--- a/datapath/flow_table.c
+++ b/datapath/flow_table.c
@@ -99,7 +99,8 @@ struct sw_flow *ovs_flow_alloc(void)
/* Initialize the default stat node. */
stats = kmem_cache_alloc_node(flow_stats_cache,
- GFP_KERNEL | __GFP_ZERO, 0);
+ GFP_KERNEL | __GFP_ZERO,
+ node_online(0) ? 0 : NUMA_NO_NODE);
if (!stats)
goto err;
--
1.9.1
More information about the dev
mailing list