[ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp

Ryan Moats rmoats at us.ibm.com
Mon Jul 18 14:37:57 UTC 2016


"dev" <dev-bounces at openvswitch.org> wrote on 07/02/2016 12:25:11 PM:

> From: Ben Pfaff <blp at ovn.org>
> To: Justin Pettit <jpettit at ovn.org>
> Cc: dev at openvswitch.org, Hui Kang <hkang.sunysb at gmail.com>
> Date: 07/02/2016 12:25 PM
> Subject: Re: [ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp
> Sent by: "dev" <dev-bounces at openvswitch.org>
>
> On Fri, Jun 24, 2016 at 12:39:54PM -0400, Hui Kang wrote:
> > These variables indicate ports in nb switches or routers.
> >
> > Signed-off-by: Hui Kang <kangh at us.ibm.com>
>
> Justin, do you want to review this?  You like naming.

I'll throw my $0.02 onto the table (and yes, it's only barely
worth $0.02) - if we are going to rename them, how about we
change them to nlsp and nlrp so that they align with the
structs that they are holding pointers to.

Ryan



More information about the dev mailing list