[ovs-dev] [PATCH v3] OVN: Fix ARP request flow in router ingresstable

Chandra Sekhar Vejendla csvejend at us.ibm.com
Mon Jul 18 17:59:39 UTC 2016



Ryan Moats/Omaha/IBM wrote on 07/18/2016 07:50:50 AM:

> From: Ryan Moats/Omaha/IBM
> To: Chandra Sekhar Vejendla/San Jose/IBM at IBMUS
> Cc: dev at openvswitch.org
> Date: 07/18/2016 07:50 AM
> Subject: Re: [ovs-dev] [PATCH v3] OVN: Fix ARP request flow in
> router ingress table
>
> "dev" <dev-bounces at openvswitch.org> wrote on 07/07/2016 05:12:48 PM:
>
> > From: Chandra Sekhar Vejendla/San Jose/IBM at IBMUS
> > To: dev at openvswitch.org
> > Date: 07/07/2016 05:13 PM
> > Subject: [ovs-dev] [PATCH v3] OVN: Fix ARP request flow in router
> > ingress table
> > Sent by: "dev" <dev-bounces at openvswitch.org>
> >
> > TPA in arp requests generated for unknown MAC-to-IP bindings is
> currently set
> > to DST_IP of the original packet. These arps will not be resolved when
the
> > DST_IP is rechable via the default gateway. This patch fixes the issue
by
> > setting the TPA to reg0. In routing stage reg0 is set to IP of the
default
> > gateway when the packet has to go through the default gateway,
> otherwise reg0
> > is set to the DST_IP of the original packet.
> >
> > Signed-off-by: Chandra Sekhar Vejendla <csvejend at us.ibm.com>
> > ---

> Given that we don't yet have e2e test coverage for this case, I'm not
> personally comfortable putting an ack on it without it including said
> test coverage.
>
> Chandra, can you please add some e2e test code that works with this
> patch, but fails when that patch isn't in place?
>
> Thanks,
> Ryan

Ack, will send out patch v2 with test code.

Thanks,
Chandra



More information about the dev mailing list